-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Vue/Vue3 wrappers' simpleEqual
helper correctly recognize the same objects.
#10896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budnix
approved these changes
Apr 8, 2024
evanSe
pushed a commit
that referenced
this pull request
Apr 17, 2024
…the same objects. (#10896) * Make the `simpleEqual` function recognize the same array passed twice as the same array. * Fix the lint errors * Add the changelog entry. * Corrent the previous commit.
evanSe
added a commit
that referenced
this pull request
May 16, 2024
* init * white space * classic * classic * dosc dev * styling v0.1 * frontend rwd * styleing * search fix * sync * vue styles leak fix * Add algolia search to documentation * add missing docsearch env error, and remove old search box component * add lint fix * fix search box results styles * scss * scss * add clear input after redirect, add fixes from qa comments * scss * scss * scss update * update review v2 * css bg / code colors * fix * review 2 part 1 - frontend * sync * visial update review 2 * hotfix RWD * sync * Update algolia docsearch to v3 * fix lint * update lock * adjust z-index * review 10.04 * code runner * hotfix * front update * feat: show examples inline * sync * Make the Vue/Vue3 wrappers' `simpleEqual` helper correctly recognize the same objects. (#10896) * Make the `simpleEqual` function recognize the same array passed twice as the same array. * Fix the lint errors * Add the changelog entry. * Corrent the previous commit. * Revert "Generate canonical links inline (#10879)" (#10898) This reverts commit a57ac39. * 1836 automate more e2e scenarios (#10901) * Change screenshot file name in visual tests and reset screenshotsCount before each test * add more e2e test scenarios * Fix datepicker position (#10892) * update dependencies (#10889) * Update dependencies in package.json * Add eslint-plugin-handsontable to package-lock.json * Remove unused dependencies from package.json * remove deprecated stylelint rules * update eslint rules to latest angular 17 * Refactor build scripts in package.json * Remove deprecated umd from angular * fix vue building * fix angular and vue tests * fix vue building issues * fix build vue * Update wrappers/react/package.json Co-authored-by: Krzysztof ‘Budzio’ Budnik <571316+budnix@users.noreply.github.com> * Fix angular examples * fix lint * fix lock --------- Co-authored-by: Krzysztof ‘Budzio’ Budnik <571316+budnix@users.noreply.github.com> * Fix date picker position in overlays (#10905) * Rollup interop fix (#10908) * update commonjs interop * add interop to base * remove from common * Generate canonicals inline (#10900) * Add fix for react only links (#10895) Co-authored-by: Evan Seaward <seaward.evan@gmail.com> * Add stackblitz improvements and codesanbox fixes (#10891) * Add stackblitz improvements and codesanbox fixes * fix lint --------- Co-authored-by: Evan Seaward <seaward.evan@gmail.com> * 14.3.0 * Regenerate package-lock with . * Fix the audit error. * 14.3.0 * 14.3.0 * update changelog and release notes (#10916) * update changelog and release notes * update url * refactor: pr feedback * update peer dependencies * revert peer bump * sync * favicon * docs frontend update - examples / algolia / roadmap * Fix links in right-hand side menu and remove smooth scroll effect (#10915) * Add breadcrumbs to documentation (#10907) * Add docs github stars counter (#10899) * Add docs github stars counter * Update docs/.vuepress/theme/components/Navbar.vue Co-authored-by: Evan Seaward <seaward.evan@gmail.com> * Update docs/.vuepress/theme/components/Navbar.vue Co-authored-by: Evan Seaward <seaward.evan@gmail.com> --------- Co-authored-by: Evan Seaward <seaward.evan@gmail.com> * Add version ticker component (#10913) * Add version ticker * Update docs/.vuepress/theme/components/InfoBox.vue Co-authored-by: Krzysztof ‘Budzio’ Budnik <571316+budnix@users.noreply.github.com> * Update docs/.vuepress/theme/components/InfoBox.vue Co-authored-by: Krzysztof ‘Budzio’ Budnik <571316+budnix@users.noreply.github.com> --------- Co-authored-by: Krzysztof ‘Budzio’ Budnik <571316+budnix@users.noreply.github.com> * docs update * docs update * css hotfix * add docs fixes round 2 * Wrap headers in ahref (#10927) * installation page & lint fix * Add right hand menu and toggle source code improvement * Fix demo disappearing on tab changes * installation page fix * Add TOC active element improvement and lint fixes * Add structured data to docs (#10880) * Add structured data to docs * add organization schema to docs config * update import * improve title and change type * fix lint * Add new docs-cover image and move script to head tag * add check if document and script element exist * lint fix * fix build * back to script inside body tag --------- Co-authored-by: Evan Seaward <seaward.evan@gmail.com> * sync * update theme * fix lint * ally issues, light theme upgrade, demos fix * DM link color ally * tabs styling * hotfix * fix lockfile * update lock * fix example checker * update cases * Add docs redesign fixes round 3 (#10960) * Add lighthouse fixes and clear console errors (#10953) * Add reset demo button functionality and fix test cases (#10946) * Add reset demo button functionality and fix test cases * update lock --------- Co-authored-by: Evan Seaward <seaward.evan@gmail.com> * fix docs build * update expected count * update lock * fix locks * bump up waiting time * update test case * update selector * update cases * introduction page update * update cases * fix cases * fix lint issues * introduction content fix * introduction rwd fix * fixes after feedback part 1 * testing push * undo * add docs final round fixes * fix examples styles * docs css hotfix icons * fix TOC (right hand menu) urls (#10969) * add installation page example fix * fix installation page on mobile * fix lint * fix infinity scroll issue * add dropdown size fix * update introduction and roadmap * add ssr link, update roadmap, update readme * grammar fix * fix icon pack styles * hotfix icon size * fix examples * Add sentry environment (#10972) * add environment to sentry init * fix linting * change default env for local runs --------- Co-authored-by: Marek Martuszewski <marekmartuszewski@Mareks-MacBook-Air.local> Co-authored-by: Marek <marek@fachowo.co> Co-authored-by: adrianspdev <adrian.dusinkiewicz@soppo.team> Co-authored-by: adrianspdev <155736789+adrianspdev@users.noreply.github.com> Co-authored-by: Jan Siegel <jansiegel@users.noreply.github.com> Co-authored-by: Krzysztof ‘Budzio’ Budnik <571316+budnix@users.noreply.github.com> Co-authored-by: Maciej Giergiczny <maciej.giergiczny@handsontable.com> Co-authored-by: Jan Siegel <js.ziggle@gmail.com>
sequba
pushed a commit
that referenced
this pull request
May 29, 2024
…the same objects. (#10896) * Make the `simpleEqual` function recognize the same array passed twice as the same array. * Fix the lint errors * Add the changelog entry. * Corrent the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes a problem where the Vue/Vue3 wrappers'
simpleEqual
function treated object-based config options as a circular reference, thus performing additional unneeded updates.How has this been tested?
Added a test case.
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: